Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix CI jobs that run on new tag, again #10537

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Feb 20, 2025

Problem

Follow up to #10525

It turns out the CI workflow configuration still contained errors

Solution

Fix the remaining configuration mistakes

How To Test

One way to test is by using https://github.com/nektos/act.

A 'tag pushed' event can be simulated like so:

  1. Create a push_tag_event.json file:
{
  "ref": "refs/tags/v1.0.0",
  "ref_type": "tag",
  "repository": {
    "full_name": "marmelab/react-admin"
  },
  "event_name": "push"
}
  1. Edit the workflow jobs so that they don't do too much stuff (typically, only echo something for instance)

  2. Run act with the event file:

act -e push_tag_event.json -W .github/workflows/test.yml
  1. Make sure the GreenFrame and update-sandbox-repository jobs are triggered

Additional Checks

  • The PR targets master for a bugfix, or next for a feature

@slax57 slax57 added the RFR Ready For Review label Feb 20, 2025
@slax57 slax57 changed the title [no ci] Fix CI jobs that run on new tag, again [chore] Fix CI jobs that run on new tag, again Feb 20, 2025
@djhi djhi merged commit b5b746c into master Feb 20, 2025
2 checks passed
@djhi djhi deleted the fix-ci-jobs-on-tagag-grid-canAccess-2 branch February 20, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants